8000 Fuzzer #215: Timestamp Arithmetic Overflow by hawkfish · Pull Request #7769 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fuzzer #215: Timestamp Arithmetic Overflow #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 5, 2023
Merged

Fuzzer #215: Timestamp Arithmetic Overflow #7769

merged 7 commits into from
Jun 5, 2023

Conversation

hawkfish
Copy link
Contributor

Use overflow testing for timestamp_t arithmetic.

Fuzzer duckdb#215: Timestamp Arithmetic Overflow
a3c9572 
Use overflow testing for timestamp_t arithmetic.
@Mytherin
Copy link
Collaborator
Mytherin commented Jun 1, 2023

Thanks for the PR! LGTM. Could you just have a look at coverage tests for the overflows and remove the trailing ;?

@hawkfish
Copy link
Contributor Author
hawkfish commented Jun 1, 2023

Looks like two of them (operator+ and operator+=) are not called anywhere.

@hawkfish
Copy link
Contributor Author
hawkfish commented Jun 1, 2023

Amusingly, the third one (operator-=) shouldn't be called! I will fix it and add a test.

@Mytherin Mytherin merged commit 59526c8 into duckdb:master Jun 5, 2023
@Mytherin
Copy link
Collaborator
Mytherin commented Jun 5, 2023

Thanks!

@hawkfish hawkfish deleted the timestamp-overflow branch June 6, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkfish @Mytherin
0