8000 Initial set of commits to add support for zOS (an IBM mainframe operating system) by v1gnesh · Pull Request #7805 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial set of commits to add support for zOS (an IBM mainframe operating system) #7805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

v1gnesh
Copy link
Contributor
@v1gnesh v1gnesh commented Jun 2, 2023

Hello!

These are mostly pre-processor directives added to support building on zOS.
I'm working on an incredibly slow zOS machine, so progressing slowly but surely.
However, I'd like to get these merged as they won't get in the way of anything else.

Thanks for this excellent product.
It's ducking hilarious seeing arbitrary tasks go from 'x' seconds to 0.x seconds, like in the 0.8 version announcement.
I heap praises on DuckDB at work whenever I get a chance.

@Mytherin
Copy link
Collaborator
Mytherin commented Jun 5, 2023

Thanks for the PR! I'm fine with merging in these changes as they don't conflict with anything else - but as we don't have any of these machines (neither ourselves nor in the CI) there's a good chance this will be broken again in the future. I also noticed you are making several changes in third party libraries we have inlined (moodycamel's concurrentqueue, httplib, fast_float). You may want to upstream these changes - otherwise once we update to a newer version the fixes will be lost.

@v1gnesh
Copy link
Contributor Author
v1gnesh commented Jun 5, 2023

Machine access - Yup, that can be a long journey, especially for zOS.
IBM Cloud has emulated zOS, but going for them isn't worth it just yet.
They're bare-bones VMs; some work will be required to set up the compilers etc.
https://community.ibm.com/community/user/ibmz-and-linuxone/blogs/sherri-hanna1/2022/09/22/i-can-do-it-mysef-wazi-as-a-service

Thank you! I'll submit PRs for those too..

@v1gnesh
Copy link
Contributor Author
v1gnesh commented Jun 5, 2023

@Mytherin, thanks again for accepting these changes.

but as we don't have any of these machines (neither ourselves nor in the CI) there's a good chance this will be broken again in the future.

Yes, I'll try to keep it in a working state. Do tag me in case anything gets broken because of this.
If it's something urgent, don't even hesitate to yank it out :)

Upstream PRs for reference. If you have time, could you see if these look ok?
yhirose/cpp-httplib#1581
cameron314/concurrentqueue#346
fastfloat/fast_float#207

@v1gnesh
Copy link
Contributor Author
v1gnesh commented Jun 13, 2023

Hi @Mytherin, could you pull this in please?

@Mytherin Mytherin changed the base branch from master to feature June 15, 2023 13:28
@Mytherin Mytherin merged commit cc119bd into duckdb:feature Jun 15, 2023
@v1gnesh
Copy link
Contributor Author
v1gnesh commented Jun 15, 2023

Thank you very much, apologies if I was rushing it.
I'm pretty new to contributing to the open source world 😅

@v1gnesh v1gnesh deleted the zos branch June 16, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0