Regression.yml to check agaist GITHUB_BASE_REF #7877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GITHUB_BASE_REF will be equal to the target branch for pull requests, and undefined, otherwise. (docs: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) Given we use the bash syntax to use variable or default (= to 'master'), this should make that pull requests against feature (or any other branch) will be tested only that given branch.
|
Tests on the fork concluded, same trivial change PR against master (https://github.com/carlopi/duckdb/actions/runs/5209821336) or against feature (https://github.com/carlopi/duckdb/actions/runs/5210054507), passes in both cases. Relevant line is for example https://github.com/carlopi/duckdb/actions/runs/5209821336/jobs/9400142270#step:12:1712 vs https://github.com/carlopi/duckdb/actions/runs/5210054507/jobs/9400676235#step:12:1731 (IMDB 07c). |
|
Thanks for picking this up! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GITHUB_BASE_REF will be equal to the target branch for pull requests, and undefined, otherwise.
(docs: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables)
Given we use the bash syntax to use variable or default (= to 'master'), this should make that pull requests against feature (or any other branch) will be tested only that given branch.
I am waiting for another round of testing on my fork, but this should address the regression on 'feature' branch.