docs: tweak explanation of median for even cardinality inputs #13726
Conversation
|
Thanks for the PR! However - this description is not quite correct. The split is not For example: D select median({'my_nested_type': i}) from range(0,10) t(i);
┌───────────────────────────────────────────────┐
│ median(main.struct_pack(my_nested_type := i)) │
│ struct(my_nested_type bigint) │
├───────────────────────────────────────────────┤
│ {'my_nested_type': 4} │
└───────────────────────────────────────────────┘Types that interpolate are numeric types and date/time types. Other types ( |
|
ahh, yes, that makes sense. Can I phrase it just as you did? (numeric, date, and time vs everything else). Maybe it's just me that is getting confused by the quantitative/qualitative, but I'd rather be verbose and explicit over succinct but possibly confusing. But this is just a value judgement, so I'm happy to keep it as is if you like it better. |
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
0219e8e to
d9ff685
Compare
|
@Mytherin I made some adjustments based on your feedback, this is ready for another review when you get the chance. Thanks! |
|
Thanks - the changeset is fine by me but the CI is failing. Can you run the formatter? |
Instead of qualitative/quantitative, I think we should be more direct and say the actual types Also, just a little more word-smithing to be explicit that we are only referring to the two middle values. This change I am less convinced is a good idea, but I still think it's a positive. Related to duckdb#13655
d9ff685 to
0bccda1
Compare
|
@Mytherin I ran the formatter, now CI is happy, I think this is good to merge if you are still happy with it. Thanks! |
|
Thanks! |
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
Instead of qualitative/quantitative, I think we should be more direct and list the actual types.
Also, just a little more word-smithing to be explicit that we are only referring to the two middle values. This change I am less convinced is a good idea, but I still think it's a positive.
Related to #13655