8000 A little cleanup. by JasonPunyon · Pull Request #16028 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A little cleanup. #16028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

A little cleanup. #16028

merged 1 commit into from
Feb 17, 2025

Conversation

JasonPunyon
Copy link
Contributor
@JasonPunyon JasonPunyon commented Feb 3, 2025 •
edited
Loading

This PR:

  1. Fixes a comment.

@Mytherin
Copy link
Collaborator

Thanks for the PR!

I'm not so sure this is removing a duplicate check for has_estimated_cardinality. EstimateCardinality is a virtual method and not all inherited methods check for this. I would leave that code as-is for now.

@JasonPunyon
Copy link
Contributor Author

Ok, just the comment then. Thanks for suffering my goof. Appreciate the explanation.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 17, 2025 20:42
@Mytherin Mytherin marked this pull request as ready for review February 17, 2025 21:17
@Mytherin Mytherin merged commit 7e72364 into duckdb:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonPunyon @Mytherin
0