[SwiftRelease CI] fetch tags before checking there is already a tag with the same name #16376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you possibly mock a test for this? Probably setting up a fork of yours, and try this either manually or in CI? |
a4858f9 to
524ce69
Compare
carlopi
approved these changes
Feb 24, 2025
carlopi
approved these changes
Feb 24, 2025
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Push Select into ArrayColumnData to avoid scanning arrays that are not required for the query (duckdb/duckdb#16356) [SwiftRelease CI] fetch tags before checking there is already a tag with the same name (duckdb/duckdb#16376)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftRelease CI fails when it tries to push with the tag name which is already exists.
The way how it checks that looks good, but maybe it should first fetch the tag names and check only then - this PR adds a line to fetch the tags.