Verify UTF-8 in DeltaLengthByteArrayDecoder and speed it up
#16328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 8-byte and 1-byte UTF-8 checking
Mytherin
reviewed
Feb 20, 2025
|
Will verification be skipped if you know the data is written by duckdb for example? |
@arjenpdevries No, we always perform the UTF-8 check. It would be a nice optimization to skip the checks if we wrote the file, but it also saves us from files that may have been tampered with. Maybe we could add a read parameter to disable the check? Although that could lead to non-UTF-8 being ingested, and I'm not sure if that would be handled gracefully, it might lead to undefined behavior. |
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Verify UTF-8 in `DeltaLengthByteArrayDecoder` and speed it up (duckdb/duckdb#16328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Parquet should be valid UTF-8, we can never be sure what other writers do, so we validate this. This validation was already there for
PLAIN/RLE_DICTIONARYencoding but was missing forDELTA_LENGTH_BYTE_ARRAY. This PR adds the verification there as well.Verifying UTF-8 takes is somewhat costly, so I've also worked on speeding it up by checking 8 bytes at a time, instead of 1 byte. This is especially nice for
DELTA_LENGTH_BYTE_ARRAY, as the strings are stored without their lengths in between, so we can verify many strings in one go.