-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Python] Add the SQLExpression method to the Expression API #16424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th it?? bit of a stretch
a3f3a08
to
ea2f27f
Compare
…t get turned into nullptr like I was expecting? - in which case adding this include would fix it
Thanks! |
Amazing, most exciting tech news of the month! If I wanted to create a SQLExpression using another duckdb expression, would E.g. would it be safe for users to do import duckdb
expr = duckdb.FunctionExpression('mean', duckdb.ColumnExpression('a'))
new_expr = duckdb.SQLExpression(f'{expr} over (partition by b)') ? For example: In [15]: rel
Out[15]:
┌───────┬───────┬───────┐
│ a │ b │ i │
│ int32 │ int32 │ int32 │
├───────┼───────┼───────┤
│ 1 │ 4 │ 0 │
│ 2 │ 5 │ 1 │
│ 1 │ 6 │ 2 │
└───────┴───────┴───────┘
In [16]: agg = duckdb.FunctionExpression('sum', duckdb.ColumnExpression('b'))
In [17]: rel.select('*', duckdb.SQLExpression(f"{agg} over (partition by a order by i rows between unbounded preceding and current row)").alias('b_cum_sum')).sort('a', 'i')
Out[17]:
┌───────┬───────┬───────┬───────────┐
│ a │ b │ i │ b_cum_sum │
│ int32 │ int32 │ int32 │ int128 │
├───────┼───────┼───────┼───────────┤
│ 1 │ 4 │ 0 │ 4 │
│ 1 │ 6 │ 2 │ 10 │
│ 2 │ 5 │ 1 │ 5 │
└───────┴───────┴───────┴───────────┘ seems to work fine, is this valid usage? |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Mention the problematic type in UNNEST BinderException (duckdb/duckdb#16429) [Python] Add the SQLExpression method to the Expression API (duckdb/duckdb#16424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues mentioned here:
#16418
#14696
#8469
With the
SQLExpression
method it's possible to create any arbitrary expression that would be possible through SQL.This is identical to what happens under the hood with
rel.select('<some arbitrary expression list>')
only the result is wrapped in anExpression
and can be used with the rest of the Expression API.