Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16637

davlee1972 · 2025-03-13T21:32:06Z

Fixed missing **kwargs. Without kwargs connect() isn't following the adbc connect() standard and can't support additional options like autocommit..

>>> c = connect(autocommit=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: connect() got an unexpected keyword argument 'autocommit'

ADBC standard:

Python 3.9.20 (main, Oct  3 2024, 07:38:01) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> import adbc_driver_duckdb
>>> import adbc_driver_manager<
8000
/span>
>>> import adbc_driver_manager.dbapi
>>>
>>>
>>> def connect(path: str = None):
...     """Connect to DuckDB via ADBC."""
...     db = None
...     conn = None
...     try:
...         db = adbc_driver_duckdb.connect(path)
...         conn = adbc_driver_manager.AdbcConnection(db)
...         return adbc_driver_manager.dbapi.Connection(db, conn)
...     except Exception:
...         if conn:
...             conn.close()
...         if db:
...             db.close()
...         raise
...
>>> c = connect(autocommit=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: connect() got an unexpected keyword argument 'autocommit'
>>>
>>> c = connect()
>>> c._autocommit
False
>>>
>>>
>>> def connect_fixed(path: str = None, **kwargs):
...     """Connect to DuckDB via ADBC."""
...     db = None
...     conn = None
...     try:
...         db = adbc_driver_duckdb.connect(path)
...         conn = adbc_driver_manager.AdbcConnection(db)
...         return adbc_driver_manager.dbapi.Connection(db, conn, **kwargs)
...     except Exception:
...         if conn:
...             conn.close()
...         if db:
...             db.close()
...         raise
...
>>> c_fixed = connect_fixed()
>>> c_fixed._autocommit
False
>>>
>>> c_fixed = connect_fixed(autocommit=False)
>>> c_fixed._autocommit
False
>>>
>>> c_fixed = connect_fixed(autocommit=True)
>>> c_fixed._autocommit
True
>>>

Fixed missing **kwargs

davlee1972 · 2025-03-13T21:37:48Z

Opened a issue for this. #16638

Tishj

Thanks!

Mytherin · 2025-03-14T13:05:27Z

Thanks!

[Dev] Clean up and fix the CGroup memory/cpu limit discovery logic (duckdb/duckdb#16608) Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() (duckdb/duckdb#16637) Add Docker support for RISC-V CI with appropriate build commands (duckdb/duckdb#16549)

kwargs fix

5d1a3a7

Fixed missing **kwargs

davlee1972 mentioned this pull request Mar 13, 2025

Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16638

Open

2 tasks

Tishj approved these changes Mar 14, 2025

View reviewed changes

Mytherin merged commit 3b20963 into duckdb:main Mar 14, 2025
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16637

Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16637

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16637

Fix missing **kwargs in adbc_driver_duckdb.dbapi.connect() #16637

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!