8000 ICU: Unify TimeZone accessing code by Mytherin · Pull Request #16887 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ICU: Unify TimeZone accessing code #16887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

ICU: Unify TimeZone accessing code #16887

merged 1 commit into from
Mar 29, 2025

Conversation

Mytherin
Copy link
Collaborator

Unify the TimeZone accessing code so that we accept the same time zones everywhere. Previously this would fail:

D select timestamptz '2020-01-01' at time zone 'utc';
Not implemented Error:
Unknown TimeZone 'utc'

But this would work:

set timezone='utc';

Similarly, we now throw the "candidates" message everywhere as well.

@Mytherin Mytherin requested a review from hawkfish March 29, 2025 07:28
@Mytherin Mytherin merged commit 86209f4 into duckdb:main Mar 29, 2025
46 of 47 checks passed
hawkfish
hawkfish reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor
@hawkfish hawkfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mytherin Mytherin deleted the tz branch April 2, 2025 09:23
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@6d19e74
fbf9714 
Rework ICU age computation to convert to a timestamp and use the regular interval age computation (duckdb/duckdb#16889)
ICU: Unify TimeZone accessing code (duckdb/duckdb#16887)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@6d19e74
dc0c98f 
Rework ICU age computation to convert to a timestamp and use the regular interval age computation (duckdb/duckdb#16889)
ICU: Unify TimeZone accessing code (duckdb/duckdb#16887)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@6d19e74
9b91a12 
Rework ICU age computation to convert to a timestamp and use the regular interval age computation (duckdb/duckdb#16889)
ICU: Unify TimeZone accessing code (duckdb/duckdb#16887)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@6d19e74
5908c2e 
Rework ICU age computation to convert to a timestamp and use the regular interval age computation (duckdb/duckdb#16889)
ICU: Unify TimeZone accessing code (duckdb/duckdb#16887)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@6d19e74
0004356 
Rework ICU age computation to convert to a timestamp and use the regular interval age computation (duckdb/duckdb#16889)
ICU: Unify TimeZone accessing code (duckdb/duckdb#16887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkfish hawkfish hawkfish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mytherin @hawkfish
0