Fix #16552: adjust join condition sequence #16943
Merged
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should yes. Sometime there are cases where a filter filters out values that would eventually cause an exception. I.e
this is a good point, something that should be investigated soon |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Fix duckdb/duckdb#16552: adjust join condition sequence (duckdb/duckdb#16943)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Fix duckdb/duckdb#16552: adjust join condition sequence (duckdb/duckdb#16943)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Fix duckdb/duckdb#16552: adjust join condition sequence (duckdb/duckdb#16943)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Fix duckdb/duckdb#16552: adjust join condition sequence (duckdb/duckdb#16943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tries to fix #16552 with just one simple idea: JoinCondition may be faster, so it should be executed first instead of arbitrary expressions.
And I have some doubts when checking this issue:
Does the order of filter expressions in sql have to be respected if any expression
CanThrow() == true?If not, then
ExpressionHeuristicsshouldn't skip optimising filter expression sequence as modified in #14672If indeed it needs to do so, then
LogicalComparisonJoin::ExtractJoinConditionsshouldn't split expressions byLogicalFilter::SplitPredicates(expressions)because this method doesn't keep original expressions sequence.