Issue #17049: ICU Date Cast #17067
Merged
Issue #17049: ICU Date Cast #17067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing DATE => TIMESTAMPTZ cast fixes: duckdb#17049 fixes: duckdblabs/duckdb-internal#4623
Tishj
approved these changes
Apr 15, 2025
|
@Mytherin can we rerun https://github.com/duckdb/duckdb/actions/runs/14388650645/job/40351540195?pr=17067 |
|
on duckdb-iceberg |
Apparently not... D select date::timestamptz from all_types;
Invalid Input Error:
Type INT32 with value 5877642-06-25 (BC) can't be cast to the destination type INT64I had convinced myself this was not an issue because none of the other casts worried about it but that's clearly wrong! |
* Add extreme date tests. fixes: duckdb#17049 fixes: duckdblabs/duckdb-internal#4623
|
@Tishj Changed the target branch and GitHub seems to be a bit grumpy about the lack of reviews... |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add bind_operator callback to TableFunction - allowing table functions to directly emit a LogicalOperator (duckdb/duckdb#17196) Issue duckdb/duckdb#17049: ICU Date Cast (duckdb/duckdb#17067) Notify JDBC repo to run Vendor.yml workflow (duckdb/duckdb#17099) Python.yml: Add back logic to perform fast-fail on Python 3.10 (duckdb/duckdb#17107)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add bind_operator callback to TableFunction - allowing table functions to directly emit a LogicalOperator (duckdb/duckdb#17196) Issue duckdb/duckdb#17049: ICU Date Cast (duckdb/duckdb#17067) Notify JDBC repo to run Vendor.yml workflow (duckdb/duckdb#17099) Python.yml: Add back logic to perform fast-fail on Python 3.10 (duckdb/duckdb#17107)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Add bind_operator callback to TableFunction - allowing table functions to directly emit a LogicalOperator (duckdb/duckdb#17196) Issue duckdb/duckdb#17049: ICU Date Cast (duckdb/duckdb#17067) Notify JDBC repo to run Vendor.yml workflow (duckdb/duckdb#17099) Python.yml: Add back logic to perform fast-fail on Python 3.10 (duckdb/duckdb#17107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be a
2C80
pplied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #17049
fixes: duckdblabs/duckdb-internal#4623