Add support for altering struct columns (adding fields, dropping fields, renaming fields) #17003
+11,037
−9,946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for altering struct columns to the SQL dialect. The syntax follows the regular
ALTER
syntax for columns - but just identifies struct fields through qualifiers.Syntax:
Adding a field
Dropping a field
Renaming a field
Implementation
The actual alter commands are currently implemented through a rewrite to a
ChangeColumnType
using astruct_remap
expression. While this works - it has the drawback that existing (unchanged) fields are also rewritten. In the future, we can work on optimizing this to work similarly to adding/dropping/renaming columns which do not touch the other columns of a table.