8000 Remove Arrow Extenson from core extensions by pdet · Pull Request #17027 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove Arrow Extenson from core extensions #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Remove Arrow Extenson from core extensions #17027

merged 1 commit into from
Apr 8, 2025

Conversation

pdet
Copy link
Contributor
@pdet pdet commented Apr 8, 2025

Removing our core arrow extension since this will be officially replaced by https://github.com/paleolimbot/duckdb-nanoarrow as a community extension.

@pdet pdet requested a review from carlopi April 8, 2025 09:11
@carlopi
Copy link
Contributor
carlopi commented Apr 8, 2025

I would consider as nice to have the ability to provide a nicer error message for scan_arrow_ipc and to_arrow_ipc, unsure how to do so without increasing too much complexity (I would think implementing them as core_functions that only generate error message, to be then overridden by other extensions?)

@carlopi
Copy link
Contributor
carlopi commented Apr 8, 2025

Changes looks reasonable, I would have assumed more changes where required, but great if this is the only surface.

@pdet
Copy link
Contributor Author
pdet commented Apr 8, 2025

I would consider as nice to have the ability to provide a nicer error message for scan_arrow_ipc and to_arrow_ipc, unsure how to do so without increasing too much complexity (I would think implementing them as core_functions that only generate error message, to be then overridden by other extensions?)

scan_arrow_ipc is not a callable SQL function anymore, so it can only be called from within a client (e.g., Python, Node).
But indeed, to_arrow_ipc still exists, and there is now a read_arrow for arrow files.

I guess the question is if we also want suggestions for community extensions, and if so, we could probably make this an automatic process since we already extract functions of community extensions anyway. (This might raise the question of what to do with duplicate function names though :-) ).

@Mytherin Mytherin merged commit 7455c07 into duckdb:main Apr 8, 2025
50 checks passed
@Mytherin
Copy link
Collaborator
Mytherin commented Apr 8, 2025

Thanks!

@carlopi carlopi added the Needs Documentation Use for issues or PRs that require changes in the documentation label Apr 8, 2025
@duckdblabs-bot duckdblabs-bot mentioned this pull request Apr 8, 2025
Closed
@jraymakers jraymakers mentioned this pull request Apr 9, 2025
Open
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@7455c07
13d1748 
Remove Arrow Extenson from core extensions (duckdb/duckdb#17027)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@7455c07
f2ed9a4 
Remove Arrow Extenson from core extensions (duckdb/duckdb#17027)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@7455c07
66aab18 
Remove Arrow Extenson from core extensions (duckdb/duckdb#17027)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@7455c07
8be2162 
Remove Arrow Extenson from core extensions (duckdb/duckdb#17027)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@7455c07
c847005 
Remove Arrow Extenson from core extensions (duckdb/duckdb#17027)
@pdet pdet deleted the remove_arrow_extension branch May 28, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlopi carlopi Awaiting requested review from carlopi

Assignees
No one assigned
Labels
Needs Documentation Use for issues or PRs that require changes in the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdet @carlopi @Mytherin
0