Move transaction cleanup outside of the transaction lock #17034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also started some nightly tests here: https://github.com/taniabogatsch/duckdb/actions/runs/14441466225 |
Mytherin
reviewed
Apr 15, 2025
|
Thanks! |
2 tasks
Mytherin
added a commit
that referenced
this pull request
Apr 15, 2025
Just a small follow-up to the review comment in #17034.
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Move transaction cleanup outside of the transaction lock (duckdb/duckdb#17034) Always parallelize `read_json` schema detection (duckdb/duckdb#17106)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Move transaction cleanup outside of the transaction lock (duckdb/duckdb#17034) Always parallelize `read_json` schema detection (duckdb/duckdb#17106)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Move transaction cleanup outside of the transaction lock (duckdb/duckdb#17034) Always parallelize `read_json` schema detection (duckdb/duckdb#17106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, transaction
Cleanuphappened immediately (1) while removing a transaction (during commit/rollback), or (2) while moving a transaction to theold_transactions(during commit/rollback). Both of these code paths happened behind a transaction lock, potentially stalling other transactions.In this PR, instead of immediately invoking a
Cleanup, we now schedule the transaction for cleanup by adding it to a newCleanupInfo. Later, we invoke theCleanupoutside the transaction lock. Because the actualCleanupnow happens outside the lock, we need to ensure any transaction can only ever be cleanup up once it has no more dependencies (once it exitsold_transactions, or on!store_transaction && transaction.ChangesMade().Additionally, not all transactions that exit
old_transactionsawait cleanup (e.g.,store_transaction, but no changes were made). Thus, this PR also introduces a new flag indicating which transactions in theCleanupInfoawaitCleanup.Related issues: