Add optional OVERRIDE_NEW_DELETE build parameter
#17035
Merged
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Clean-up virtual columns and make MultiFileReader::InitializeReader virtual (duckdb/duckdb#17038) Add optional `OVERRIDE_NEW_DELETE` build parameter (duckdb/duckdb#17035)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Clean-up virtual columns and make MultiFileReader::InitializeReader virtual (duckdb/duckdb#17038) Add optional `OVERRIDE_NEW_DELETE` build parameter (duckdb/duckdb#17035)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Clean-up virtual columns and make MultiFileReader::InitializeReader virtual (duckdb/duckdb#17038) Add optional `OVERRIDE_NEW_DELETE` build parameter (duckdb/duckdb#17035)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Clean-up virtual columns and make MultiFileReader::InitializeReader virtual (duckdb/duckdb#17038) Add optional `OVERRIDE_NEW_DELETE` build parameter (duckdb/duckdb#17035)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Clean-up virtual columns and make MultiFileReader::InitializeReader virtual (duckdb/duckdb#17038) Add optional `OVERRIDE_NEW_DELETE` build parameter (duckdb/duckdb#17035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with jemalloc enabled, this parameter allows you to override the C++
new/deleteoperators.This can basically only be used for our CLI build, because when DuckDB is loaded as a dynamic library, we cannot override
new/delete, as we risk mixing up different allocators.Usage:
OVERRIDE_NEW_DELETE=1 make.CC @szarnyasg