[Dev] Generate the EXTENSION_SECRET_TYPES instead of hardcoding them
#17183
+88
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Mytherin
added a commit
that referenced
this pull request
Apr 30, 2025
….py` for dependencies between extensions (#17204) This PR is a follow-up to #17183 To elaborate on that last part: In `add_extension` we first check if there are dependencies (hardcoded in the `EXTENSION_DEPENDENCIES` dictionary) if there are, we make sure to call `add_extension` for those first, if they are not in the `added_extensions` set already. In the various `add_<catalog entry type>` methods, we previously only subtracted the `base_<catalog entry type>` set. Now we check the dependencies and also subtract the entries added by the dependencies of the extension, tracked by the `extension_<catalog entry type>` dictionary. This is also where we update the `extension_<catalog entry type>` dictionary. At the end of `add_extension` we add to the `added_extensions` set.
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Generate the `EXTENSION_SECRET_TYPES` instead of hardcoding them (duckdb/duckdb#17183)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Generate the `EXTENSION_SECRET_TYPES` instead of hardcoding them (duckdb/duckdb#17183)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Dev] Generate the `EXTENSION_SECRET_TYPES` instead of hardcoding them (duckdb/duckdb#17183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expansion of #11623
Instead of hardcoding the secret types we use
duckdb_secret_typesto generate the list, this PR can also serve as a good example of how to add new generation functionality to the script (there are many more catalog types that are hardcoded still)