Add "thousands" option to CSV Reader #17220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option called
thousandsto the CSV reader. It accepts a single character used to identify thousands separators in decimal, float, or double values.By default, thousands is set to
NULL. If specified, it must be different from thedecimal_separatoroption.When dealing with misplaced thousands separators, we follow the same approach as pandas: simply remove them from the string and ignore whether they were correct.
The option has also been added to the Python client.
Fix: #17093
Fix: #15678
Fix: #6578
Fix: #16632
Fix: #6154