Handle both ENCRYPTION_KEY and STORAGE_VERSION passed as options #17357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86425e0 to
e33dfd1
Compare
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Handle both ENCRYPTION_KEY and STORAGE_VERSION passed as options (duckdb/duckdb#17357) Support --directories option in format.py (duckdb/duckdb#17354) Add support for BENCHMARK_ROOT_DIRECTORY cmake option to change benchmark runner root directory, and add support for cache_file and reload options to enable better caching for non-DuckDB databases (duckdb/duckdb#17355) Pass commit ID to NotifyExternalRepositories.yml (duckdb/duckdb#17333)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Handle both ENCRYPTION_KEY and STORAGE_VERSION passed as options (duckdb/duckdb#17357) Support --directories option in format.py (duckdb/duckdb#17354) Add support for BENCHMARK_ROOT_DIRECTORY cmake option to change benchmark runner root directory, and add support for cache_file and reload options to enable better caching for non-DuckDB databases (duckdb/duckdb#17355) Pass commit ID to NotifyExternalRepositories.yml (duckdb/duckdb#17333)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Handle both ENCRYPTION_KEY and STORAGE_VERSION passed as options (duckdb/duckdb#17357) Support --directories option in format.py (duckdb/duckdb#17354) Add support for BENCHMARK_ROOT_DIRECTORY cmake option to change benchmark runner root directory, and add support for cache_file and reload options to enable better caching for non-DuckDB databases (duckdb/duckdb#17355) Pass commit ID to NotifyExternalRepositories.yml (duckdb/duckdb#17333)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Handle both ENCRYPTION_KEY and STORAGE_VERSION passed as options (duckdb/duckdb#17357) Support --directories option in format.py (duckdb/duckdb#17354) Add support for BENCHMARK_ROOT_DIRECTORY cmake option to change benchmark runner root directory, and add support for cache_file and reload options to enable better caching for non-DuckDB databases (duckdb/duckdb#17355) Pass commit ID to NotifyExternalRepositories.yml (duckdb/duckdb#17333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre this PR
GetStorageOptionswould possibly set the same settings via 2 different paths viaENCRYPTION_KEYorSTORAGE_VERSION, potentially ending up discarding user input and leading to confusing situations.This should fix that, and add a relevant test.