[Dev] Add QualifiedName::ParseComponents, add input to the error messages
#17403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Add `QualifiedName::ParseComponents`, add input to the error messages (duckdb/duckdb#17403)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Add `QualifiedName::ParseComponents`, add input to the error messages (duckdb/duckdb#17403)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Dev] Add `QualifiedName::ParseComponents`, add input to the error messages (duckdb/duckdb#17403)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Dev] Add `QualifiedName::ParseComponents`, add input to the error messages (duckdb/duckdb#17403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm slightly abusing the
QualifiedName::Parsemethod in iceberg (duckdb/duckdb-iceberg#224), which causes a problem when the path contains multiple dots.I'm adding
QualifiedName::ParseComponentsso we can make use of the parsing logic safely.One other thing that stood out to me was that an empty input is not invalid, which feels wrong, but I preserved the behavior in this change.