Pass MultiFileGlobalState to InitializeReader, and pass file list to CreateMapping instead of eagerly getting the first file #17553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2022 GitHub deprecated the `set-output` commands: https://github.blog/changelog/2022-10-10-github-actions-deprecating-save-state-and-set-output-commands/ `set-output` is used in the `build_extensions_dockerized` workflow and triggers warnings when the `LinuxRelease.yml` workflow runs. This change resolves the warning.
In 2022 GitHub deprecated the `set-output` commands: https://github.blog/changelog/2022-10-10-github-actions-deprecating-save-state-and-set-output-commands/ `set-output` is used in the `build_extensions_dockerized` workflow and triggers warnings when the `LinuxRelease.yml` workflow runs [[recent example](https://github.com/duckdb/duckdb/actions/runs/15063088936)]: >  This change resolves the warning.
…CreateMapping instead of eagerly getting the first file
|
MFR Refactor #20 ;) |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Pass MultiFileGlobalState to InitializeReader, and pass file list to CreateMapping instead of eagerly getting the first file (duckdb/duckdb#17553)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Pass MultiFileGlobalState to InitializeReader, and pass file list to CreateMapping instead of eagerly getting the first file (duckdb/duckdb#17553)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Pass MultiFileGlobalState to InitializeReader, and pass file list to CreateMapping instead of eagerly getting the first file (duckdb/duckdb#17553)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 23, 2025
Pass MultiFileGlobalState to InitializeReader, and pass file list to CreateMapping instead of eagerly getting the first file (duckdb/duckdb#17553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the global state to be referenced in these callbacks