Minor fixes to exception error messages #17528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a call to the exception constructor does not have any parameters we shouldn't call the format function at all, no? In template <typename... ARGS>
static string ConstructMessage(const string &msg, ARGS... params) {
const std::size_t num_args = sizeof...(ARGS);
if (num_args == 0) {
return msg;
}
std::vector<ExceptionFormatValue> values;
return ConstructMessageRecursive(msg, values, params...);
}
This is only really a problem when mixing string addition and formatting. |
|
Either way, thanks for the fixes! |
|
You are right, I am not sure what I saw then, possibly the throw was elsewhere where indeed format + parameters are there. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Minor fixes to exception error messages (duckdb/duckdb#17528)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Minor fixes to exception error messages (duckdb/duckdb#17528)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Minor fixes to exception error messages (duckdb/duckdb#17528)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 23, 2025
Minor fixes to exception error messages (duckdb/duckdb#17528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor, I bumped on those, they can be as well be fixed.
The fix at src/main/extension.cpp would need to be generalized, there might be other places where we construct exception messages from unsanitized strings, and while that is handled by Format function, then error that is then re-throw bumps to InternalError and it's not super clear.
My proposal would be to change exceptions to take a
const char *instead of a string, so that string concatenation is forbidden while constant strings are still allowed.But this requires changes in many places, and not a point fix.
Either
v1.3-ossivalisormain, both are fine, this is minor.