8000 Use duckdb format.py script instead of find, add support for CRASH_ON_ASSERT pass-through by Mytherin · Pull Request #174 · duckdb/extension-ci-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use duckdb format.py script instead of find, add support for CRASH_ON_ASSERT pass-through #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Use duckdb format.py script instead of find, add support for CRASH_ON_ASSERT pass-through #174

merged 2 commits into from
May 22, 2025

Conversation

Mytherin
Copy link
Contributor
@Mytherin Mytherin commented May 4, 2025

The find command does not work on MacOS - so make format does not format anything. We should just use DuckDB's format script.

Note this relies on duckdb/duckdb#17354

In addition we add support for the CRASH_ON_ASSERT flag to being passed through to the CMake config

@carlopi
8000
Copy link
Collaborator
carlopi commented May 4, 2025

This looks good to me, failures are fixed via #175

@adsharma
Copy link
adsharma commented May 5, 2025 
brew install findutils

and using gfind instead of find is another way of fixing this.

@adsharma adsharma mentioned this pull request May 5, 2025
Merged
@Mytherin Mytherin merged commit 45dc929 into duckdb:main May 22, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mytherin @carlopi @adsharma
0