8000 Tell LGTM to ignore unused imports in stub.py by jwodder · Pull Request #179 · duecredit/duecredit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tell LGTM to ignore unused imports in stub.py #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2021
Merged

Tell LGTM to ignore unused imports in stub.py #179

merged 2 commits into from
Jun 8, 2021

Conversation

jwodder
Copy link
Contributor
@jwodder jwodder commented Jun 8, 2021

As requested here.

@codecov-commenter
Copy link
codecov-commenter commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #179 (e36c3f6) into master (a5cd404) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   83.41%   83.29%   -0.12%     
==========================================
  Files          47       47              
  Lines        2388     2437      +49     
  Branches      259      259              
==========================================
+ Hits         1992     2030      +38     
- Misses        324      332       +8     
- Partials       72       75       +3
Impacted Files Coverage Δ
duecredit/stub.py 72.00% <100.00%> (ø)
duecredit/entries.py 88.46% <0.00%> (-3.21%) ⬇️
duecredit/tests/test_versions.py 92.00% <0.00%> (-1.88%) ⬇️
duecredit/tests/test_api.py 89.79% <0.00%> (-1.61%) ⬇️
duecredit/tests/test_injections.py 97.19% <0.00%> (-1.10%) ⬇️
duecredit/versions.py 93.15% <0.00%> (-0.97%) ⬇️
duecredit/io.py 80.60% <0.00%> (-0.69%) ⬇️
duecredit/tests/test_io.py 99.41% <0.00%> (+<0.01%) ⬆️
duecredit/injections/injector.py 79.61% <0.00%> (+0.19%) ⬆️
duecredit/utils.py 37.06% <0.00%> (+0.22%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cd404...e36c3f6. Read the comment docs.

yarikoptic
yarikoptic reviewed Jun 8, 2021
View reviewed changes
duecredit/stub.py
@@ -52,7 +52,7 @@ def _donothing_func(*args, **kwargs):


try:
from duecredit import due, BibTeX, Doi, Url, Text
from duecredit import due, BibTeX, Doi, Url, Text # lgtm [py/unused-import]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

thank you. Could you please adjust while at it the above

Copyright:  2015-2019
... 
__version__ = '0.0.8'

with current year and beef version to 0.0.9 ? (can't suggest right here since not in a diff)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged and removed release Create a release when this pr is merged labels Jun 8, 2021
@yarikoptic
Copy link
Member

thank you @jwodder. Decided not to pester anything with a release for this minor change.

@yarikoptic yarikoptic merged commit 0345105 into duecredit:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwodder @codecov-commenter @yarikoptic
0