Drop python 3.6 and 3.7 and pyupgrade to 3.8 #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below ===
{
"chain": [],
"cmd": "pyupgrade --exit-zero-even-if-changed --py38-plus setup.py duecredit/cmdline/cmd_summary.py duecredit/cmdline/cmd_test.py duecredit/cmdline/common_args.py duecredit/cmdline/helpers.py duecredit/cmdline/__init__.py duecredit/cmdline/main.py duecredit/collector.py duecredit/config.py duecredit/dueswitch.py duecredit/entries.py duecredit/__init__.py duecredit/injections/__init__.py duecredit/injections/injector.py duecredit/injections/mod_biosig.py duecredit/injections/mod_dipy.py duecredit/injections/mod_matplotlib.py duecredit/injections/mod_mdp.py duecredit/injections/mod_mne.py duecredit/injections/mod_nibabel.py duecredit/injections/mod_nipype.py duecredit/injections/mod_nipy.py duecredit/injections/mod_numpy.py duecredit/injections/mod_pandas.py duecredit/injections/mod_psychopy.py duecredit/injections/mod_scipy.py duecredit/injections/mod_skimage.py duecredit/injections/mod_sklearn.py duecredit/io.py duecredit/log.py duecredit/__main__.py duecredit/parsers.py duecredit/stub.py duecredit/tests/envs/nolxml/lxml.py duecredit/tests/__init__.py duecredit/tests/mod/imported.py duecredit/tests/mod/__init__.py duecredit/tests/mod/submod.py duecredit/tests/test_api.py duecredit/tests/test_cmdline.py duecredit/tests/test_collector.py duecredit/tests/test_dueswitch.py duecredit/tests/test_entries.py duecredit/tests/test_injections.py duecredit/tests/test_io.py duecredit/tests/test__main__.py duecredit/tests/test_utils.py duecredit/tests/test_versions.py duecredit/utils.py duecredit/version.py duecredit/versions.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 47 47
Lines 2517 2517
Branches 365 365
=======================================
Hits 2039 2039
Misses 383 383
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I don't see changes for Union & Optional. I guess pyupgrade needs some parameter flag. |
|
https://github.com/asottile/pyupgrade#pep-604-typing-rewrites suggests that it is 3.10 feature |
|
I read this as "either 3.10 or 3.8+using from future import annotoations", but it's new information for me too. |
might as well be, and just pyupgrade doesn't do such RFings automagically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.