8000 fix: re-add missing topic selector checks by dunglas · Pull Request #597 · dunglas/mercure · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: re-add missing topic selector checks #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 26, 2021
Merged

fix: re-add missing topic selector checks #597

merged 4 commits into from
Dec 26, 2021

Conversation

dunglas
Copy link
Owner
@dunglas dunglas commented Dec 23, 2021 •
edited
Loading

Fix #596.

It's very concerning that our test suite didn't catch that. We need to thoroughly test that all existing behaviors still work.

TODO:

  • Add tests covering this
  • Double-check that JWT support still works as expected
  • Double-check that subscriptions still work as expected
  • Maybe can we replace the canReceive() function by subscriber.Match()?

8000
@dunglas dunglas mentioned this pull request Dec 24, 2021
Closed
@dunglas dunglas merged commit b2adf74 into main Dec 26, 2021
@dunglas dunglas deleted the fix/security branch December 26, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topic selection does not work
1 participant
@dunglas
0