8000 fix: storageClassName indent by VincentDugard · Pull Request #894 · dunglas/mercure · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: storageClassName indent #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: storageClassName indent #894

merged 1 commit into from
Apr 9, 2024

Conversation

VincentDugard
Copy link
Contributor

@CLAassistant
Copy link
CLAassistant commented Apr 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VincentDugard VincentDugard mentioned this pull request Apr 8, 2024
Closed
dunglas
dunglas approved these changes Apr 8, 2024
View reviewed changes
Copy link
Owner
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. Can you just sign the CLA, please?

@VincentDugard
Copy link
Contributor Author

I signed, but I guess there is delay ?
image

@dunglas
Copy link
Owner
dunglas commented Apr 8, 2024

It is usually instant. Did you used the same email as the one you used for the Git commit?

@VincentDugard VincentDugard force-pushed the storage-class-indent branch from 02468fd to 7cab435 Compare April 9, 2024 06:22
@VincentDugard
Copy link
Contributor Author

Indeed, that was a wrong email in the first commit. This is fixed

@dunglas dunglas merged commit c9f42a6 into dunglas:main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentDugard @CLAassistant @dunglas
0