Rewrote the repair for scenarios where remote files are missing. #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a number of additional features to the repair process so it can actually fully recover if all data is present. Also added a several tests to ensure that the functionality works in multiple scenarios. This fixes #5987
… source data is available. This repair will leave the database in a still-broken state, but if this is run prior to purge-broken-files, less data will be lost. Also updated the purge-broken-files operation to keep files and directories in the set, if they are only missing metadata.
Fix indentation. Move metadata check up.
Fixed issue with the full/partial state not being replicated for re-created filesets
This reverts commit 513e674.
…use they are somehow deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of additional features to the repair process so it can actually fully recover if all data is present.
Also added a several tests to ensure that the functionality works in multiple scenarios.
Also added functionality to do partial recovery where some data is available locally.
This makes it possible to first run a "repair" to recover as much data as possible, and then run purge-broken-files after to ensure that the backups retain as much content as possible.
With this change, it is also possible to recover files that are only lacking metadata, and the purge-broken-files command will by default try to assign a different set of metadata to files to avoid them being purged.
This fixes #5987