(fix) improve handling of unhealthy websockets connections (backport #2854) #2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, publishing errors were caught on each attempt to send a message from a batch to a subscriber. Now, encountering an error in publishing will stop publishing to that subscriber, minimizing redundant error generation. Before, when a websocket client would fail to respond to pings, it was disconnected by termination and cleanup. Now, the websocket is closed with an error appropriate for heartbeat timeout. In the event the websocket is healthy but the subscriber is not responding to pings, they will receive the informative error. Remove unnecessary typed buffer conversions. Minimize connection lookups by passing Connection and not ConnectionId. Add connectionId to `Connection` for use in logging and error generation. Extract metrics to methods for clarity in critical code segments. Simplify error handling in wss send. Add constants for websocket error codes. Remove ad-hoc listener removal in InvalidMessageHandler. (cherry picked from commit e9d1551)
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
UnbornAztecKing
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Publishing errors were caught on each attempt to send a message from a batch to a subscriber. Now, first error in publishing to a subscriber will break the publishing loop, minimizing redundant error generation.
Websockets that failed to respond to pings were terminated and cleaned up without an attempt to close the connection with an informative error.
remove unnecessary typed buffer conversions
minimize connection lookups by passing Connection and not id
add connectionId to
Connectionextract metrics to methods for clarity
simplify error handling in wss send
add constants for websocket error codes
remove ad-hoc listener removal in InvalidMessageHandler
Test Plan
Unit Tests
Run in internal environments and public testnet
Summary by CodeRabbit
This is an automatic backport of pull request #2854 done by [Mergify](https://mergify.com).