10000 Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal by teddyding · Pull Request #20 · dydxprotocol/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal #20

merged 1 commit into from
Sep 6, 2023

Conversation

teddyding
Copy link
@teddyding teddyding commented Sep 6, 2023 •
edited
Loading

Port over two changes from cometbft/cometbft main in state.go:

cometbft#1208: Add check for non-nil in enterCommit
cometbft#1079: Log proposer's address when correctly accepting a proposal

Omitted changes in state_test.go since only upstream PRs only include formatting changes

@linear
Copy link
linear bot commented Sep 6, 2023

CORE-524 Update testnet3 documentations

@teddyding teddyding changed the title Cherrypicks: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal Sep 6, 2023
@teddyding teddyding changed the title Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal cherrypick: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal Sep 6, 2023
@teddyding teddyding changed the title cherrypick: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal Backport: Add check for non-nil in enterCommit + Log proposer's address when accepting a proposal Sep 6, 2023
@teddyding teddyding merged commit ad47306 into dydx-fork-v0.37.2 Sep 6, 2023
@teddyding teddyding deleted the td/CORE-524-2 branch September 6, 2023 14:17
@teddyding
Copy link
Author

Test / tests (03) (pull_request) is currently timing out; however the test TestDontExhaustMaxActiveIDs passes locally and this PR has no affect on peering/reactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrendanChou BrendanChou BrendanChou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddyding @BrendanChou
0