Integration test stabilization #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -80,7 +80,7 @@ sudo debuginfo-install kernel-${UNAME%.*} | |||
| sudo yum install gcc-plugin-devel | |||
|
|
|||
| # optional, but highly recommended | |||
| sudo yum install https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/c/ccache-3.3.4-1.el7.x86_64.rpm | |||
| sudo yum install https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/c/ccache-3.7.6-1.el7.x86_64.rpm | |||
There was a problem hiding this comment.
I have a kpatch setup script that just installs the epel, ccache and then removes epel to avoid this issue. Feel free to steal it if you are tired of updating these. (It should probably check to see if epel was installed originally, but I only use the script on test boxes.)
# ccache from EPEL
yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-${RHEL}.noarch.rpm
yum install -y ccache
ccache --max-size=5G
yum erase -y epel-releaseThere was a problem hiding this comment.
That is a great suggestion, I'll apply that.
joe-lawrence
approved these changes
Jan 23, 2020
jpoimboe
reviewed
Jan 24, 2020
test/integration/vm-integration-run
Outdated
| @@ -63,6 +63,12 @@ if [[ -d "${HOME}/src" && -f "${HOME}/src/version" ]]; then | |||
| mv "${HOME}/src" "${HOME}/.kpatch/" | |||
| fi | |||
|
|
|||
| source /etc/os-release | |||
|
|
|||
| if [[ "${NAME}" == "Fedora" ]] && [[ "${VERSION_ID}" -le 27 ]]; then | |||
There was a problem hiding this comment.
Why <= 27? I think CONFIG_LIVEPATCH is disabled for all versions of Fedora?
There was a problem hiding this comment.
Ah, I didn't realize that. This is not entirely true though, starting with fc30 we do have it enabled: https://src.fedoraproject.org/rpms/kernel/c/3792ab811f3d097b7883cf43235c75ea410b3ebc
I'll fix this up.
There was a problem hiding this comment.
Ah, nice... I'm glad Fedora enabled it, that will make it easier to test with new kernels.
Eventually we may want to have a rolling "latest Fedora" set of integration tests to catch regressions with new kernels.
julien-thierry
approved these changes
Jan 24, 2020
ccache version in epel updates from time to time so instead of using a direct link install epel repo and install ccache without specifying the version. Suggested-by: Joe Lawrence <joe.lawrence@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
Disabled due to dynup#940. Please re-enable this test once it is fixed. Signed-off-by: Artem Savkov <asavkov@redhat.com>
This is supposedly fixed by dynup#1054 and should be reinabled once that is merged. Signed-off-by: Artem Savkov <asavkov@redhat.com>
This is supposedly fixed by dynup#1053 and should be re-enabled when it is merged. Signed-off-by: Artem Savkov <asavkov@redhat.com>
…bling call
These patches cause the following error on ppc64le on both 7.7 and 7.6:
create-diff-object: ERROR: export.o: kpatch_no_sibling_calls_ppc64le: 3290: Found an unsupported sibling call at e_show()+0x100. Add __attribute__((optimize("-fno-optimize-sibling-calls"))) to e_show() definition.
Adding -fno-optimize-sibling-calls breaks build on x86_64, so limit it
to ppc64le only.
Signed-off-by: Artem Savkov <asavkov@redhat.com>
We recently disabled building kmod by default, make sure fedora-27 (and others before fc30) integration tests still build that. Signed-off-by: Artem Savkov <asavkov@redhat.com>
Relay KPATCH_GIT and KPATCH_REV into vagrant so it can checkout specified repo/commit. Signed-off-by: Artem Savkov <asavkov@redhat.com>
"vagrant" target's should be 'vagrant-quick', not 'vagrant_quick'. Signed-off-by: Artem Savkov <asavkov@redhat.com>
dd9a98b to
272761d
Compare
|
v2:
|
kamalesh-babulal
approved these changes
Jan 24, 2020
jpoimboe
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits disable/fix a bunch of test and small issues in order to make integration tests on all of the supported distros pass.