remove build pass from kpatch-build #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we use the vmlinux from the distro debug package we don't need to do any build runs without -ffunction-sections -fdata-sections. Old: Build orig in objdir Build patched in objdir Build orig w/ flags in objdir2 Copy orig .o's into orig Build patched w/ flags in objdir2 Copy patched .o's into patched New: Build orig w/ flags in objdir Build patched w/ flags in objdir Copy patched .o's into patched Build orig w/ flags in objdir Copy orig .o's into orig This commit also does try to build each change object singularly since there are cases in the kernel tree where the Makefile does not reside in the same directory as the changed object. Signed-off-by: Seth Jennings <sjenning@redhat.com>
| rm -rf "$OBJDIR2" | ||
| mkdir -p "$OBJDIR2" | ||
| cp "$OBJDIR/.config" "$OBJDIR2" || die | ||
| echo "Copying changed objects" |
There was a problem hiding this comment.
Perhaps this echo isn't needed, since the copying happens almost instantaneously and can probably be considered an extension of "Detecting changed objects"?
Signed-off-by: Seth Jennings <sjenning@redhat.com>
jpoimboe
added a commit
that referenced
this pull request
Jul 23, 2014
remove build pass from kpatch-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use the vmlinux from the distro debug package we don't need
to do any build runs without -ffunction-sections -fdata-sections.
Old:
Build orig in objdir
Build patched in objdir
Build orig w/ flags in objdir2
Copy orig .o's into orig
Build patched w/ flags in objdir2
Copy patched .o's into patched
New:
Build orig w/ flags in objdir
Build patched w/ flags in objdir
Copy patched .o's into patched
Build orig w/ flags in objdir
Copy orig .o's into orig
This commit also does not try to build each changed object singularly since
there are cases in the kernel tree where the Makefile does not reside in
the same directory as the changed object.
Signed-off-by: Seth Jennings sjenning@redhat.com
Improves upon #325