Fix reloading if files are replaced #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On linux inotify is tied to the inode, so if the files are replaced (rather than re-written in place) the previous code wouldn't be watching the new files. The fix instead watches the diretory and then reloads when filenames matching the original names are modified. Another issue I ran into was the vault agent having a small window between updating the certificate and key, so the reloading would always have a noisy "key and cert don't match" error. Fix this by always waiting 2 seconds after a change to do the reload.
Bump go and use go modules.
Logs were prefixed with "certman: " however this imposes an odd format on the logging. The injected logger is a better place to do any prefixing if desired or to perform structured logging, etc. The "certman: " prefix has been removed from all log lines.
Use shields.io for version badge in README.
BREAKING CHANGES: - Replace custom logger interface with standard log/slog - Remove public Logger() method in favor of WithLogger() option - Change constructor to accept functional options - Require Go 1.21+ for slog support Features: - Add WithLogger() and WithContext() functional options - Use context.Context for graceful shutdown - Structured logging with Info, Error, and Debug levels - Add comprehensive CLAUDE.md for AI-assisted development This modernizes the API to use Go's standard structured logging and provides a cleaner, more extensible interface through functional options pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.