8000 fix(crux): deployment deletes containers by robot9706 · Pull Request #703 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(crux): deployment deletes containers #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix(crux): deployment deletes containers #703

merged 3 commits into from
Jun 21, 2023

Conversation

robot9706
Copy link
Contributor

Deleting a deployment should only delete containers if the deployment is successful.

@robot9706 robot9706 requested a review from a team as a code owner June 20, 2023 12:14
@robot9706 robot9706 self-assigned this Jun 20, 2023
@github-actions github-actions bot added pr:fix lang:typescript source:web The scope of the issue or pull request is web. labels Jun 20, 2023
@polaroi8d polaroi8d merged commit 33bd226 into develop Jun 21, 2023
@polaroi8d polaroi8d deleted the fix/deployment-container-delete branch June 21, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@robot9706 robot9706

Labels
lang:typescript pr:fix severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robot9706 @m8vago @polaroi8d
0