8000 feat: use events to track container states in agents by robot9706 · Pull Request #718 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: use events to track container states in agents #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 5, 2023
Merged

feat: use events to track container states in agents #718

merged 26 commits into from
Jul 5, 2023

Conversation

robot9706
Copy link
Contributor

Instead of polling containers use docker events to only track changes and notify crux if something happened.

@robot9706 robot9706 self-assigned this Jun 27, 2023
@github-actions github-actions bot added lang:golang lang:typescript source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web. pr:feat labels Jun 27, 2023
@robot9706 robot9706 force-pushed the feat/agent-watch-events branch 2 times, most recently from 9449553 to 012ff37 Compare June 28, 2023 09:47
@codecov-commenter
Copy link
codecov-commenter commented Jun 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 27.46% and project coverage change: +1.20 🎉

Comparison is base (5d3c38f) 23.41% compared to head (f63b28c) 24.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #718      +/-   ##
===========================================
+ Coverage    23.41%   24.61%   +1.20%     
===========================================
  Files           55       55              
  Lines         5292     5509     +217     
===========================================
+ Hits          1239     1356     +117     
- Misses        3959     4048      +89     
- Partials        94      105      +11
Impacted Files Coverage Δ
golang/internal/grpc/grpc.go 0.00% <0.00%> (ø)
golang/pkg/crane/k8s/delete_facade.go 0.00% <0.00%> (ø)
golang/pkg/crane/k8s/deployment.go 11.25% <0.00%> (-1.25%) ⬇️
golang/pkg/crane/k8s/log.go 0.00% <0.00%> (ø)
golang/pkg/dagent/utils/docker.go 3.17% <0.00%> (ø)
golang/internal/mapper/grpc.go 66.31% <33.33%> (+3.72%) ⬆️
golang/pkg/dagent/utils/dockerhelper.go 36.92% <50.52%> (+36.92%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robot9706 robot9706 force-pushed the feat/agent-watch-events branch 2 times, most recently from 3d91b9b to 7ece48a Compare June 28, 2023 13:18
@robot9706 robot9706 marked this pull request as ready for review June 28, 2023 13:44
@robot9706 robot9706 requested a review from a team as a code owner June 28, 2023 13:44
nandor-magyar
nandor-magyar requested changes Jun 29, 2023
View reviewed changes
m8vago
m8vago requested changes Jun 29, 2023
View reviewed changes
@robot9706 robot9706 marked this pull request as draft June 29, 2023 14:56
@robot9706 robot9706 force-pushed the feat/agent-watch-events branch 4 times, most recently from 2acef95 to 27c1aff Compare July 4, 2023 12:23
@robot9706 robot9706 force-pushed the feat/agent-watch-events branch from 8f7990d to 44ba994 Compare July 4, 2023 12:30
@robot9706 robot9706 marked this pull request as ready for review July 4, 2023 12:30
@robot9706 robot9706 changed the title feat: use docker events to track container states in dagent feat: use events to track container states in agents Jul 5, 2023
@nandor-magyar nandor-magyar merged commit b3befcb into develop Jul 5, 2023
@nandor-magyar nandor-magyar deleted the feat/agent-watch-events branch July 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@robot9706 robot9706

Labels
lang:golang lang:typescript pr:feat severity:medium source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robot9706 @codecov-commenter @m8vago @nandor-magyar
0