8000 feat(dagent): add useParent functionality to dagent by nandor-magyar · Pull Request #721 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(dagent): add useParent functionality to dagent #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2023
Merged

feat(dagent): add useParent functionality to dagent #721

merged 4 commits into from
Jul 3, 2023

Conversation

nandor-magyar
Copy link
Contributor

It was implemented a while ago in our crane, but it was missing from dagent.

@nandor-magyar nandor-magyar 8000 requested a review from a team as a code owner July 3, 2023 10:33
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:cli The scope of the issue or pull request is CLI tool. lang:golang lang:makefile source:build Makefiles, Dockerfiles, etc labels Jul 3, 2023
@codecov-commenter
Copy link
codecov-commenter commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 20.58% and project coverage change: -0.34 ⚠️

Comparison is base (33c1a1c) 23.41% compared to head (6121457) 23.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #721      +/-   ##
===========================================
- Coverage    23.41%   23.07%   -0.34%     
===========================================
  Files           55       55              
  Lines         5245     5291      +46     
===========================================
- Hits          1228     1221       -7     
- Misses        3927     3982      +55     
+ Partials        90       88       -2
Impacted Files Coverage Δ
golang/pkg/builder/container/types.go 65.21% <ø> (ø)
golang/pkg/dagent/utils/docker.go 3.17% <0.00%> (-0.09%) ⬇️
golang/pkg/dagent/utils/import_container.go 13.33% <0.00%> (ø)
golang/pkg/dagent/utils/init_container.go 0.00% <0.00%> (ø)
golang/pkg/builder/container/container_builder.go 30.98% <20.00%> (-0.68%) ⬇️
golang/internal/helper/image/image.go 45.92% <28.20%> (-6.86%) ⬇️
golang/pkg/builder/container/docker_container.go 28.07% <41.17%> (+3.62%) ⬆️
golang/internal/mapper/grpc.go 62.58% <100.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nandor-magyar nandor-magyar force-pushed the feat/dagent-use-parent branch from cb20c2a to 33d7bf3 Compare July 3, 2023 10:37
polaroi8d
polaroi8d approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

robot9706
robot9706 requested changes Jul 3, 2023
View reviewed changes
@nandor-magyar nandor-magyar requested a review from robot9706 July 3, 2023 13:29
@robot9706
Copy link
Contributor

Tested, init containers seem to use their name as their image name, and the containers do not actually have any environment variables.

robot9706
robot9706 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor
@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to be working fine 🎈

@nandor-magyar nandor-magyar merged commit 594cdd6 into develop Jul 3, 2023
@nandor-magyar nandor-magyar deleted the feat/dagent-use-parent branch July 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels
lang:golang lang:makefile pr:feat source:agent The scope of the issue or pull request is agent. source:build Makefiles, Dockerfiles, etc source:cli The scope of the issue or pull request is CLI tool.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nandor-magyar @codecov-commenter @robot9706 @polaroi8d
0