8000 fix(dagent): correct entrypoint and cmd for init containers by nandor-magyar · Pull Request #729 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(dagent): correct entrypoint and cmd for init containers #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix(dagent): correct entrypoint and cmd for init containers #729

merged 2 commits into from
Jul 6, 2023

Conversation

nandor-magyar
Copy link
Contributor

Entrypoint and command mapping into init containers was missing.

@nandor-magyar nandor-magyar requested a review from a team as a code owner July 5, 2023 15:22
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang labels Jul 5, 2023
@github-actions github-actions bot added the pr:fix label Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@3bbc51f). Click here to learn what that means.
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop     #729   +/-   ##
==========================================
  Coverage           ?   24.63%           
==========================================
  Files              ?       55           
  Lines              ?     5509           
  Branches           ?        0           
==========================================
  Hits               ?     1357           
  Misses             ?     4047           
  Partials           ?      105
Impacted Files Coverage Δ
golang/pkg/dagent/utils/init_container.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@polaroi8d polaroi8d merged commit b320855 into develop Jul 6, 2023
@polaroi8d polaroi8d deleted the fix/agent-init-args-commands branch July 6, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels
lang:golang pr:fix source:agent The scope of the issue or pull request is agent.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandor-magyar @codecov-commenter @polaroi8d
0