8000 refactor(crux): refactor http response status codes for request handlers by AmorfEvo · Pull Request #733 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(crux): refactor http response status codes for request handlers #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2023
Merged

refactor(crux): refactor http response status codes for request handlers #733

merged 2 commits into from
Jul 7, 2023

Conversation

AmorfEvo
Copy link
Contributor
@AmorfEvo AmorfEvo commented Jul 6, 2023

We use the built-in Nest.js HttpStatus enums as @httpcode parameters instead of magic numbers.

@AmorfEvo AmorfEvo requested a review from a team as a code owner July 6, 2023 17:08
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript labels Jul 6, 2023
@AmorfEvo AmorfEvo changed the title Refactor HTTP response status codes for request handlers refactor(crux): refactor http response status codes for request handlers Jul 6, 2023
polaroi8d
polaroi8d requested changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the scope and the type of the PR in the commit message.

@AmorfEvo AmorfEvo force-pushed the refactor/http-response-status-codes branch from b99e85c to 4582f7a Compare July 7, 2023 08:26
polaroi8d
polaroi8d approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks.

@polaroi8d polaroi8d merged commit 13c2268 into develop Jul 7, 2023
@polaroi8d polaroi8d deleted the refactor/http-response-status-codes branch July 7, 2023 11:22
@polaroi8d polaroi8d linked an issue Jul 10, 2023 that may be closed by this pull request
Refactor HTTP response status codes for request handlers #731
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@AmorfEvo AmorfEvo

Labels
lang:typescript pr:refactor source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor HTTP response status codes for request handlers
3 participants
@AmorfEvo @robot9706 @polaroi8d
0