8000 feat: unchecked registry use local images by robot9706 · Pull Request #745 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: unchecked registry use local images #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 12, 2023
Merged

feat: unchecked registry use local images #745

merged 6 commits into from
Jul 12, 2023

Conversation

robot9706
Copy link
Contributor

No description provided.

@robot9706 robot9706 self-assigned this Jul 12, 2023
@robot9706 robot9706 changed the title Feat/registry local images feat: unchecked registry use local images Jul 12, 2023
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. source:cli The scope of the issue or pull request is CLI tool. lang:golang lang:typescript pr:feat labels Jul 12, 2023
@codecov-commenter
Copy link
codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 37.14% and project coverage change: +0.19 🎉

Comparison is base (21ac69f) 24.61% compared to head (3e726dc) 24.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
+ Coverage    24.61%   24.81%   +0.19%     
===========================================
  Files           55       55              
  Lines         5512     5524      +12     
===========================================
+ Hits          1357     1371      +14     
+ Misses        4049     4048       -1     
+ Partials       106      105       -1
Impacted Files Coverage Δ
golang/internal/helper/image/types.go 0.00% <ø> (ø)
golang/pkg/dagent/utils/docker.go 3.16% <0.00%> (-0.03%) ⬇️
golang/pkg/builder/container/container_builder.go 32.53% <55.00%> (+1.34%) ⬆️
golang/internal/helper/image/image.go 57.19% <100.00%> (+2.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robot9706 robot9706 marked this pull request as ready for review July 12, 2023 10:52
@robot9706 robot9706 requested a review from a team as a code owner July 12, 2023 10:52
m8vago
m8vago requested changes Jul 12, 2023
View reviewed changes
polaroi8d
polaroi8d approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works so LGTM.

@polaroi8d polaroi8d merged commit a278802 into develop Jul 12, 2023
@polaroi8d polaroi8d deleted the feat/registry-local-images branch July 12, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@robot9706 robot9706

Labels
lang:golang lang:typescript pr:feat severity:medium source:agent The scope of the issue or pull request is agent. source:cli The scope of the issue or pull request is CLI tool. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robot9706 @codecov-commenter @m8vago @polaroi8d
0