8000 feat(web): add team slug by m8vago · Pull Request #752 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web): add team slug #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Aug 1, 2023
Merged

feat(web): add team slug #752

merged 26 commits into from
Aug 1, 2023

Conversation

m8vago
Copy link
Contributor
@m8vago m8vago commented Jul 18, 2023 •
edited
Loading
  • Add team slug
  • Remove active team from the database
  • Add team slug to relevant api endpoints
  • Save the last team slug to cookie

@m8vago m8vago requested a review from a team as a code owner July 18, 2023 12:40
@m8vago m8vago marked this pull request as draft July 18, 2023 12:40
@m8vago m8vago marked this pull request as ready for review July 20, 2023 13:21
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript lang:sql labels Jul 20, 2023
@robot9706
Copy link
Contributor

Tried testing few things:

After creating the first team, the redirect to dashboard fails.

Unhandled Runtime Error
TypeError: Cannot read properties of null (reading 'dashboard')

Source
src\pages\[teamSlug]\dashboard.tsx (42:44) @ dashboard

  40 | const handleApiError = defaultApiErrorHandler(t)
  41 | 
> 42 | const { data } = useSWR<Dashboard>(routes.dashboard.api(), fetcher)
     |                                          ^
  43 | 
  44 | const dashboard = data ?? propsDashboard

Creating a new node results in: ERROR [HTTP] 404 POST /api/ada/nodes {"property":"team","message":"No Team found"}

@ngyradi
Copy link
Contributor
ngyradi commented Jul 25, 2023

Creating a project works, but it's not possible to open it.
I couldn't open the registries page or create a project from templates.

@ngyradi
Copy link
Contributor
ngyradi commented Jul 31, 2023 •
edited
Loading

Tested locally, deployment works.

Slug can't be changed in team edit page.
Deleting notifications doesn't seem to work.

@robot9706
Copy link
Contributor
robot9706 commented Jul 31, 2023 •
edited
Loading
  1. Accepting and declining a team invite throws an Unhandled Exception.
TypeError: Expected a string but received a undefined
    at assertString (C:\Work\dyo\dyrectorio\web\crux\node_modules\validator\lib\util\assertString.js:17:11)
    at Object.isUUID (C:\Work\dyo\dyrectorio\web\crux\node_modules\validator\lib\isUUID.js:22:29)
    at C:\Work\dyo\dyrectorio\web\crux\src\guards\uuid-params.validation.guard.ts:29:22
    at Array.forEach (<anonymous>)
    at UuidValidationGuard.canActivate (C:\Work\dyo\dyrectorio\web\crux\src\guards\uuid-params.validation.guard.ts:26:12)
    at GuardsConsumer.tryActivate (C:\Work\dyo\dyrectorio\web\crux\node_modules\@nestjs\core\guards\guards-consumer.js:15:34)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at canActivateFn (C:\Work\dyo\dyrectorio\web\crux\node_modules\@nestjs\core\router\router-execution-context.js:134:33)
    at C:\Work\dyo\dyrectorio\web\crux\node_modules\@nestjs\core\router\router-execution-context.js:42:31
    at C:\Work\dyo\dyrectorio\web\crux\node_modules\@nestjs\core\router\router-proxy.js:9:17
  1. Deployment token generated URL seems to be wrong, it's missing the team slug.

@m8vago m8vago requested a review from robot9706 July 31, 2023 16:25
@m8vago m8vago merged commit b4ca709 into develop Aug 1, 2023
@m8vago m8vago deleted the refactor/stateless-api branch August 1, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

Assignees

@m8vago m8vago

Labels
lang:sql lang:typescript pr:feat source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m8vago @robot9706 @ngyradi
308A
0