8000 refactor(crux-ui): useConfirmation by robot9706 · Pull Request #761 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(crux-ui): useConfirmation #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2023
Merged

refactor(crux-ui): useConfirmation #761

merged 3 commits into from
Jul 25, 2023

Conversation

robot9706
Copy link
Contributor
  • Remove params from useConfirmation() (already done)
  • Remove callback from confirm() and make override params required
  • Remove default params from all <DyoConfirmationModal>s

@robot9706 robot9706 requested a review from a team as a code owner July 24, 2023 12:10
@robot9706 robot9706 self-assigned this Jul 24, 2023
@github-actions github-actions bot added pr:refactor source:web The scope of the issue or pull request is web. lang:typescript labels Jul 24, 2023
@m8vago m8vago merged commit af37049 into develop Jul 25, 2023
@m8vago m8vago deleted the refactor/use-confirmation branch July 25, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

Assignees

@robot9706 robot9706

Labels
lang:typescript pr:refactor severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robot9706 @m8vago
0