8000 feat(web): node in use by robot9706 · Pull Request #763 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web): node in use #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

feat(web): node in use #763

merged 3 commits into from
Jul 25, 2023

Conversation

robot9706
Copy link
Contributor
  • Show node in use message when editing a node.
  • Show error when trying to delete a node which is in use.

@robot9706 robot9706 requested a review from a team as a code owner July 24, 2023 13:49
@robot9706 robot9706 self-assigned this Jul 24, 2023
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript pr:feat labels Jul 24, 2023
@ngyradi
Copy link
Contributor
ngyradi commented Jul 25, 2023

tested locally, looks good

Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polaroi8d polaroi8d merged commit 46302c7 into develop Jul 25, 2023
@polaroi8d polaroi8d deleted the feat/node-in-use branch July 25, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:typescript pr:feat severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0