8000 feat(web): updated Kratos to v1.0 by robot9706 · Pull Request #771 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web): updated Kratos to v1.0 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2023
Merged

feat(web): updated Kratos to v1.0 #771

merged 4 commits into from
Aug 1, 2023

Conversation

robot9706
Copy link
Contributor
@robot9706 robot9706 commented Jul 27, 2023 •
edited
Loading
  • Updated Kratos to v1.0
  • Updated kratos client npm package to v0.13.1
  • Fixed a bug on the verify page, showing email as "null" and the email not showing up when the user is logged in
  • Reverted enable/disable identity patches since Kratos fixed the identity patch bug

@robot9706 robot9706 self-assigned this Jul 27, 2023
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript source:build Makefiles, Dockerfiles, etc source:kratos Ory Kratos related changes in the codebase. and removed pr:feat labels Jul 27, 2023
@robot9706 robot9706 marked this pull request as ready for review July 28, 2023 06:27
@robot9706 robot9706 requested a review from a team as a code owner July 28, 2023 06:27
@ngyradi
Copy link
Contributor
ngyradi commented Jul 28, 2023

Tested locally, registration, verification and logging in works.

When restarting verification it's possible to change the email, but it doesn't get sent unless it matches the one entered during registration.
When changing your profile's email the verification code is sent to the new address to confirm.

@m8vago
Copy link
Contributor
m8vago commented Jul 28, 2023

The code looks good. @robot9706 Please resolve the issues Adam mentioned, then we can merge this.

@polaroi8d
Copy link
Collaborator

Do not merge.

@robot9706 robot9706 merged commit f9afa53 into develop Aug 1, 2023
@robot9706 robot9706 deleted the feat/kratos-1 branch August 1, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

Assignees

@robot9706 robot9706

Labels
lang:typescript pr:feat severity:medium source:build Makefiles, Dockerfiles, etc source:kratos Ory Kratos related changes in the codebase. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robot9706 @ngyradi @m8vago @polaroi8d
0