8000 fix: container builder image priority by robot9706 · Pull Request #779 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: container builder image priority #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2023
Merged

fix: container builder image priority #779

merged 6 commits into from
Aug 10, 2023

Conversation

robot9706
Copy link
Contributor

Added PullIfNewer image priority and set it as default for the container builder. This priority pulls the image if the digests mismatch.

@robot9706 robot9706 self-assigned this Aug 3, 2023
@codecov-commenter
Copy link
codecov-commenter commented Aug 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.06% ⚠️

Comparison is base (82e3dfe) 25.54% compared to head (0bf5ba4) 25.49%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #779      +/-   ##
===========================================
- Coverage    25.54%   25.49%   -0.06%     
===========================================
  Files           60       60              
  Lines         5703     5703              
===========================================
- Hits          1457     1454       -3     
- Misses        4145     4147       +2     
- Partials       101      102       +1
Files Changed Coverage Δ
golang/internal/helper/image/types.go 0.00% <ø> (ø)
golang/internal/helper/image/image.go 56.08% <75.00%> (-1.11%) ⬇️
golang/pkg/builder/container/container_builder.go 42.93% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the pr:fix label Aug 3, 2023
@robot9706 robot9706 marked this pull request as ready for review August 3, 2023 06:25
@robot9706 robot9706 requested review from a team as code owners August 3, 2023 06:25
polaroi8d
polaroi8d approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

nandor-magyar
nandor-magyar approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor
@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robot9706 robot9706 merged commit ab10117 into develop Aug 10, 2023
@robot9706 robot9706 deleted the fix/image-pull-priority branch August 10, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@robot9706 robot9706

Labels
lang:golang pr:fix severity:medium
Projects
None yet
Milestone
No milestone
4014
Development

Successfully merging this pull request may close these issues.
4 participants
@robot9706 @codecov-commenter @polaroi8d @nandor-magyar
0