8000 chore(crux): fix vm2 critical vuln using npm audit fix by nandor-magyar · Pull Request #793 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(crux): fix vm2 critical vuln using npm audit fix #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2023
Merged

chore(crux): fix vm2 critical vuln using npm audit fix #793

merged 2 commits into from
Aug 21, 2023

Conversation

nandor-magyar
Copy link
Contributor

This solves the vm2 critical vulnerability that was given by dependabot.

@nandor-magyar nandor-magyar requested a review from a team as a code owner August 17, 2023 15:28
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. pr:chore labels Aug 17, 2023
@nandor-magyar nandor-magyar force-pushed the chore/resolve-vm2-vulnerability branch from cee1ac7 to 0cfc4de Compare August 17, 2023 15:55
polaroi8d
polaroi8d approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706
Copy link
Contributor

Getting the same error as the pipeline when trying to npm i:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for vm2@^4.6.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

@nandor-magyar
Copy link
Contributor Author

Now it is good.

@nandor-magyar nandor-magyar force-pushed the chore/resolve-vm2-vulnerability branch 2 times, most recently from 2ddea79 to e9e19a5 Compare August 18, 2023 09:36
@nandor-magyar nandor-magyar force-pushed the chore/resolve-vm2-vulnerability branch from e9e19a5 to c84ef1b Compare August 21, 2023 07:25
@polaroi8d polaroi8d merged commit 791859e into develop Aug 21, 2023
@polaroi8d polaroi8d deleted the chore/resolve-vm2-vulnerability branch August 21, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes 5695

Assignees

@nandor-magyar nandor-magyar

Labels
pr:chore source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandor-magyar @robot9706 @polaroi8d
0