8000 feat(web): crane metrics config by robot9706 · Pull Request #797 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web): crane metrics config #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 30, 2023
Merged

feat(web): crane metrics config #797

merged 12 commits into from
Aug 30, 2023

Conversation

robot9706
Copy link
Contributor

Added metrics (crane only) config to image and instance editors.

@robot9706 robot9706 self-assigned this Aug 23, 2023
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:golang lang:typescript lang:sql and removed pr:feat labels Aug 23, 2023
@codecov-commenter
Copy link
codecov-commenter commented Aug 23, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (cb41303) 25.49% compared to head (1b303a5) 25.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #797      +/-   ##
===========================================
- Coverage    25.49%   25.46%   -0.03%     
===========================================
  Files           60       60              
  Lines         5703     5709       +6     
===========================================
  Hits          1454     1454              
- Misses        4147     4152       +5     
- Partials       102      103       +1
Files Changed Coverage Δ
golang/internal/mapper/grpc.go 64.63% <0.00%> (-0.80%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot9706 robot9706 marked this pull request as ready for review August 23, 2023 13:44
@robot9706 robot9706 requested a review from a team as a code owner August 23, 2023 13:44
polaroi8d
polaroi8d requested changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, (talked about some missing features in-person). Added minor reviews.

nandor-magyar
nandor-magyar reviewed Aug 25, 2023
View reviewed changes
m8vago
m8vago requested changes Aug 29, 2023
View reviewed changes
@robot9706 robot9706 requested review from m8vago and polaroi8d August 30, 2023 11:07
@m8vago m8vago merged commit 22a6e26 into develop Aug 30, 2023
@m8vago m8vago deleted the feat/crane-metrics branch August 30, 2023 12:36
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@robot9706 @chandhuDev
feat(web): crane metrics config (dyrector-io#797)
508009e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandor-magyar nandor-magyar nandor-magyar left review comments

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@robot9706 robot9706

Labels
lang:golang lang:sql lang:typescript pr:feat severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
3FD3
Development

Successfully merging this pull request may close these issues.
5 participants
@robot9706 @codecov-commenter @m8vago @polaroi8d @nandor-magyar
0