8000 feat: service category label for platform containers & hide containers based on category by robot9706 · Pull Request #807 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: service category label for platform containers & hide containers based on category #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2023
Merged

feat: service category label for platform containers & hide containers based on category #807

merged 6 commits into from
Sep 5, 2023

Conversation

robot9706
Copy link
Contributor
  • CLI adds org.dyrectorio.service-category=_internal labels to all platform containers.
  • Added labels to agent container proto.
  • Hide containers if their service category starts with an underscore or their kubernetes namespace is kube-system.

@robot9706 robot9706 requested a review from a team as a code owner September 1, 2023 13:39
@robot9706 robot9706 self-assigned this Sep 1, 2023
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. source:cli The scope of the issue or pull request is CLI tool. lang:golang lang:typescript source:proto Protobuf related changes. labels Sep 1, 2023
@codecov-commenter
Copy link
codecov-commenter commented Sep 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 20.00% and no project coverage change.

Comparison is base (81aee61) 24.13% compared to head (a1ab545) 24.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #807   +/-   ##
========================================
  Coverage    24.13%   24.13%           
========================================
  Files           62       62           
  Lines         5954     5958    +4     
========================================
+ Hits          1437     1438    +1     
- Misses        4411     4414    +3     
  Partials       106      106
Files Changed Coverage Δ
golang/internal/label/label.go 0.00% <0.00%> (ø)
golang/internal/mapper/grpc.go 64.57% <33.33%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@polaroi8d
Copy link
Collaborator

Please add new labels to docker compose and CLI containers.

nandor-magyar
nandor-magyar approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor
@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

polaroi8d
polaroi8d requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeError: Cannot read properties of undefined (reading 'org.dyrectorio.service-category')

polaroi8d
polaroi8d approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator
@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally.

@polaroi8d polaroi8d merged commit da12e4c into develop Sep 5, 2023
@polaroi8d polaroi8d deleted the feat/label-service-category branch September 5, 2023 12:17
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@robot9706 @chandhuDev
feat: service category label for platform containers & hide container…
9ddb8f5 
…s based on category (dyrector-io#807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@robot9706 robot9706

Labels
lang:golang lang:typescript pr:feat severity:medium source:cli The scope of the issue or pull request is CLI tool. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robot9706 @codecov-commenter @polaroi8d @m8vago @nandor-magyar
0