8000 feat(web): merge postgress instances by polaroi8d · Pull Request #1049 · dyrector-io/dyrectorio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web): merge postgress instances #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2025
Merged

feat(web): merge postgress instances #1049

merged 4 commits into from
Mar 18, 2025

Conversation

polaroi8d
Copy link
Collaborator

We had two PostgreSQL instances instead of one. This PR merges them into a single instance and refactors the docker-compose.yaml files accordingly.

I skipped the cli refactor because, after discussing with the internal team, we decided to use docker compose instead of the CLI.

@polaroi8d polaroi8d requested a review from a team as a code owner March 17, 2025 14:05
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:shell source:ci Workflow files source:build Makefiles, Dockerfiles, etc labels Mar 17, 2025
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 17, 2025 14:44 — with GitHub Actions Inactive
nandor-magyar
nandor-magyar reviewed Mar 17, 2025
View reviewed changes
@polaroi8d polaroi8d force-pushed the feat/multi-db-docker branch from 26107b5 to 5bb166a Compare March 18, 2025 10:42
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 10:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.05%. Comparing base (bcf4ab5) to head (5bb166a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1049   +/-   ##
========================================
  Coverage    12.05%   12.05%           
========================================
  Files          301      301           
  Lines        11188    11188           
  Branches      1176     1176           
========================================
  Hits          1349     1349           
  Misses        9814     9814           
  Partials        25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 11:01 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 11:18 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 11:20 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 15:57 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 16:45 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:14 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:18 — with GitHub Actions Inactive
@polaroi8d polaroi8d force-pushed the feat/multi-db-docker branch from 394949f to c20adf1 Compare March 18, 2025 17:20
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:20 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:22 — with GitHub Actions Inactive
@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:23 — with GitHub Actions Inactive
nandor-magyar
nandor-magyar reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor
@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, only one little thing with script.

@polaroi8d polaroi8d temporarily deployed to Workflow - Protected March 18, 2025 17:41 — with GitHub Actions Inactive
@nandor-magyar nandor-magyar merged commit d0ba469 into develop Mar 18, 2025
24 checks passed
@nandor-magyar nandor-magyar deleted the feat/multi-db-docker branch March 18, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@polaroi8d polaroi8d

Labels
lang:shell pr:feat source:build Makefiles, Dockerfiles, etc source:ci Workflow files source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polaroi8d @codecov-commenter @nandor-magyar
0