-
Notifications
You must be signed in to change notification settings - Fork 10
feat: implement autopprof pkg #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlsrb6342
reviewed
Oct 25, 2022
proost
reviewed
Oct 25, 2022
dlsrb6342
approved these changes
Oct 25, 2022
proost
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
두구두구 가보겠읍니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
메모리 사용률 (CPU는 곧 지원 예정)이 지정된 threshold 값을 넘을 경우 알람을 리포트 해주는 라이브러리를 만들었어요.
동작 방식은 단순하게 일정 주기마다 cgroups stat으로부터 limit, usage를 읽어와 rate를 계산해서 threshold 값과 비교한 뒤 높으면 알람을 보내는 방식이에요. 추가로 고려했던건, 보통 mem leak 등으로 메모리 사용률이 높아지면 높아진 상태에서 유지되는 경우가 많기 때문에 threshold를 넘길때마다 보내지는 않고 연속적으로 threshold를 넘는 최소 수치를 카운팅하면서 최소 카운트를 넘어가면 다시 보내는 로직을 구현했습니다. (스팸성 리포트 방지)