8000 feat(react): Add option `useDeferredStack` to disable use of `useDeferredValue` by tonyfromundefined · Pull Request #540 · daangn/stackflow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(react): Add option useDeferredStack to disable use of useDeferredValue #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tonyfromundefined
Copy link
Member
@tonyfromundefined tonyfromundefined commented Nov 19, 2024

Note

The part that integrates coreStore with React and changes it to State has been moved from the existing Provider to the top of the component.

Copy link
vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Dec 2, 2024 2:34am

Copy link
changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: ea5f499

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tonyfromundefined tonyfromundefined marked this pull request as ready for review December 2, 2024 02:31
@tonyfromundefined tonyfromundefined changed the title WIP: add useDeferredStack flag in stackflow() initialization feat(react): Add option useDeferredStack to disable use of useDeferredValue Dec 2, 2024
@tonyfromundefined tonyfromundefined requested review from ENvironmentSet and removed request for orionmiz February 7, 2025 05:44
@ENvironmentSet
Copy link
Contributor

After investigation on the actual problem case and days of discussion, we've concluded that this is not a desirable change nor proper solution for the problem. Thus we close this PR.

Here I left summarized reasons of closing.

  1. Navigations should be transitions
  2. If you feel navigations being transitions are delivering slow UX then you should check if you've implemented it as 'refreshing' transition.
  3. Nest suspense boundary wisely to control order of content revealing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0